Skip to content

datadog-agent: update go packages and sub-packages #56567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 6, 2019
Merged

datadog-agent: update go packages and sub-packages #56567

merged 5 commits into from
Mar 6, 2019
+376 −270

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Mar 1, 2019 •
edited
Loading

Motivation for this change

Update go packages and sub-packages.
Datadog-trace-agent moved to datadog-agent - https://github.com/DataDog/datadog-trace-agent/blob/moved/README.md
Update datadog-process-agent to version 6.10.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Izorkin added 4 commits March 1, 2019 10:06
@Izorkin
datadog-agent: update go packages

Verified

This commit was signed with the committer’s verified signature. The key has expired.
kalbasit Wael Nasreddine
GPG key ID: FD437548E0BF0F5F
Expired
Verified
Learn about vigilant mode
c915e47
@Izorkin
datadog-agent: update sub-packages
19b61b9
@Izorkin
datadog-trace-agent: trace-agent moved to datadog-agent
35b6943
@Izorkin
datadog-process-agent: 6.5.0 -> 6.10.0
ce2ef06
@Izorkin Izorkin requested a review from infinisil as a code owner March 1, 2019 08:04
@Izorkin
Copy link
Contributor Author

Izorkin commented Mar 1, 2019

cc @kalbasit @rvl

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 1, 2019
@kalbasit
Copy link
Member

kalbasit commented Mar 1, 2019 •
edited
Loading

I'm not able to build this PR locally.

 λ  nix-shell -p nix-review --run 'nix-review pr 56567'
these paths will be fetched (0.02 MiB download, 0.09 MiB unpacked):
  /nix/store/4g4vr4154qn7dv4l03hxjjbiv83xn5cm-nix-review-1.0.1
copying path '/nix/store/4g4vr4154qn7dv4l03hxjjbiv83xn5cm-nix-review-1.0.1' from 'https://cache.nixos.org'...
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/56567/head:refs/nix-review/1
remote: Enumerating objects: 31, done.
remote: Counting objects: 100% (31/31), done.
remote: Total 35 (delta 31), reused 31 (delta 31), pack-reused 4
Unpacking objects: 100% (35/35), done.
From https://github.com/NixOS/nixpkgs
   ab9c2c11483..81bf897e294  master               -> refs/nix-review/0
 + 2d178c80d65...ce2ef06c353 refs/pull/56567/head -> refs/nix-review/1  (forced update)
$ git worktree add /yl/.cache/nix-review/pr-56567/nixpkgs 81bf897e294a27b59b73f6a76942b1405923e99e
Preparing worktree (detached HEAD 81bf897e294)
HEAD is now at 81bf897e294 python.pkgs.filetype: 1.0.4 -> 1.0.5
$ git merge --no-commit ce2ef06c353ae6aeca843c0da9f9fe363c1b2bd7
Auto-merging pkgs/top-level/all-packages.nix
Removing pkgs/tools/networking/dd-agent/datadog-trace-agent.nix
Removing pkgs/tools/networking/dd-agent/datadog-trace-agent-deps.nix
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --max-jobs 12 --option build-use-sandbox true -f /yl/.cache/nix-review/pr-56567/build.nix
cannot build on 'ssh://builder@zeus.home.nasreddine.com': cannot connect to 'builder@zeus.home.nasreddine.com': ssh: Could not resolve hostname zeus.home.nasreddine.com: Name or service not known
builder for '/nix/store/1c4g69ylvqf09axw7bmr00fdcl34wz02-python2.7-pg8000-1.13.1.drv' failed with exit code 1; last 10 log lines:
  adding 'pg8000-1.13.1.dist-info/METADATA'
  adding 'pg8000-1.13.1.dist-info/WHEEL'
  adding 'pg8000-1.13.1.dist-info/top_level.txt'
  adding 'pg8000-1.13.1.dist-info/RECORD'
  removing build/bdist.linux-x86_64/wheel
  installing
  /build/pg8000-1.13.1/dist /build/pg8000-1.13.1
  DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7.
  Processing ./pg8000-1.13.1-py2-none-any.whl
  pg8000 requires Python '>=3.5' but the running Python is 2.7.15
cannot build derivation '/nix/store/abm5xrdpc8zb6pl0n95g5600xfnc88vk-python2.7-datadog-integration-postgres-git-2018-09-18.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/s2ww4k354qq5i6czpw51fb2mkjdf028g-python-2.7.15-env.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/48gvv1gcdfpk9k5vimjpfrpiypdr2kjl-datadog-agent-6.10.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/x40gz316np53s19j7hd2iyramnr2d5wz-env.drv': 1 dependencies couldn't be built
[44 built (1 failed), 230 copied (972.9 MiB), 222.5 MiB DL]
error: build of '/nix/store/x40gz316np53s19j7hd2iyramnr2d5wz-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/56567
1 package failed to build:
datadog-agent

1 package were build:
datadog-process-agent

@kalbasit
Copy link
Member

kalbasit commented Mar 1, 2019

@GrahamcOfBorg build datadog-agent datadog-process-agent

@Izorkin
Copy link
Contributor Author

Izorkin commented Mar 1, 2019

In rev c60d946 normal build

@Izorkin
Copy link
Contributor Author

Izorkin commented Mar 1, 2019

cc @FRidh
Datadog error build with latest updates. Error build package python2.7-pg8000-1.13.1. Need version 1.12.5

@kalbasit
Copy link
Member

kalbasit commented Mar 2, 2019

@Izorkin it's recommended to fix the issue rather than a downgrade of a package.

@Izorkin Izorkin requested a review from FRidh as a code owner March 2, 2019 09:37
@kalbasit
Copy link
Member

kalbasit commented Mar 4, 2019

@GrahamcOfBorg build datadog-agent datadog-process-agent

@kalbasit kalbasit merged commit 51fdca9 into NixOS:master Mar 6, 2019
@Izorkin
Copy link
Contributor Author

Izorkin commented Mar 6, 2019

Thanks!

@Izorkin Izorkin deleted the datadog-agent branch March 6, 2019 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

@FRidh FRidh

@garbas garbas

@domenkozar domenkozar

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: clean-up 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @kalbasit @GrahamcOfBorg