Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stepmania: 5.0.12 -> 5.1.0-b2 #56765

Merged
merged 2 commits into from Mar 14, 2019
Merged

stepmania: 5.0.12 -> 5.1.0-b2 #56765

merged 2 commits into from Mar 14, 2019

Conversation

RubenAstudillo
Copy link
Contributor

Motivation for this change

The build on 5.0.12 fails to start with message "Fatal: crash from within the crash signal handler". This was solved on the 5.1 branch as said on stepmania's github, so we update.

Things done

Update the version field, hash and output directory to 5.1.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

Oh, I just merged #56977 which also fixes this issue, although not as nicely. Can you rebase on top of current master and revert #56977 in this PR?

@kyren
Copy link
Contributor

kyren commented Mar 9, 2019

For reference the related stepmania issue is here: stepmania/stepmania#1606

I actually still think it might be miscompilation by gcc, but since they've worked around it, I agree it's probably nicer to just update.

@RubenAstudillo RubenAstudillo deleted the stepmania-5.1 branch March 9, 2019 10:57
@infinisil
Copy link
Member

Closed by accident?

@RubenAstudillo RubenAstudillo restored the stepmania-5.1 branch March 9, 2019 22:13
@RubenAstudillo
Copy link
Contributor Author

RubenAstudillo commented Mar 9, 2019 •
edited

Yeah, I don't how that happened. Sorry.

@infinisil infinisil merged commit aa5df94 into NixOS:master Mar 14, 2019
@RubenAstudillo RubenAstudillo deleted the stepmania-5.1 branch March 15, 2019 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RubenAstudillo @infinisil @kyren @GrahamcOfBorg