Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trezor luks #56551

Closed
wants to merge 7 commits into from
Closed

Trezor luks #56551

wants to merge 7 commits into from

Conversation

petrkr
Copy link

@petrkr petrkr commented Feb 28, 2019 •
edited

Motivation for this change

Because in our company switch from debian-based distro to NixOs, we need to make sure our trezor will work here as-well. That was motivation for this change.

Things done

support of trezor cipher value and initrd for trezor support

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@petrkr petrkr changed the base branch from master to release-18.09 February 28, 2019 23:57
@petrkr petrkr mentioned this pull request Mar 17, 2019
Closed
@petrkr
Copy link
Author

petrkr commented Mar 17, 2019

Updated license.. Is there chance about use this in mainstream? I need some update for Mondays meeting at work :)

@petrkr
Copy link
Author

petrkr commented Apr 5, 2019

Closing as I working on different library which will use newer trezor libraries. PR #58968

@petrkr petrkr closed this Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil left review comments

@jb55 jb55 jb55 requested changes

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@petrkr @jb55 @infinisil @GrahamcOfBorg