Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytjon.pkgs.wptserve: correctly fix build #56743

Merged
merged 2 commits into from Mar 3, 2019
Merged

pytjon.pkgs.wptserve: correctly fix build #56743

merged 2 commits into from Mar 3, 2019

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Robert Schütz added 2 commits March 3, 2019 02:40
Revert "pythonPackages.wptserve: fix build by adding a local h2 3.0.1…
a2c2f89 
… instance"

This reverts commit 3e603b1.
Python packages' dependencies should not be overridden because
having multiple versions in $PYTHONPATH breaks stuff.
python.pkgs.wptserve: relax h2 version constraint
639a85c
@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 3, 2019
@dotlambda dotlambda requested a review from 7c6f434c March 3, 2019 01:44
@dotlambda dotlambda requested a review from FRidh as a code owner March 3, 2019 01:44
@FRidh FRidh merged commit 3c4c8b6 into NixOS:master Mar 3, 2019
@FRidh
Copy link
Member

FRidh commented Mar 3, 2019

cc @7c6f434c

@FRidh
Copy link
Member

FRidh commented Mar 3, 2019

cherry-picked to staging-19.03 as well

@7c6f434c
Copy link
Member

7c6f434c commented Mar 3, 2019

To be honest, I am a bit surprised wptserve survived that bump (but indeed it did). Sorry, was too pessimistic.

@dotlambda
Copy link
Member Author

If you want, we can use fetchFromGitHub or ask upstream to include the tests in the PyPI tarball in order to add a checkPhase.

@7c6f434c
Copy link
Member

7c6f434c commented Mar 3, 2019

Well, the only in-tree user is Marionette harness (and the end-to-end process is easy to test), and I fail to understand whether upstream wants just to switch to Rust step by step.

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dotlambda @FRidh @7c6f434c @samueldr @GrahamcOfBorg