xournalpp: init at 1.0.8 #56748
Merged
xournalpp: init at 1.0.8 #56748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-d
force-pushed
the
adunham/xournalpp
branch
from
50c0633
to
85e641d
Compare
hedning
reviewed
Mar 3, 2019
|
Runs and works with my wacom tablet in gnome on wayland 👍 |
andrew-d
force-pushed
the
adunham/xournalpp
branch
2 times, most recently
from
afa04bb
to
c585592
Compare
|
@hedning did you see the tool icons? For me, a lot of them are missing… |
|
Yeah, I've got icons. Might be some version mismatch or something (I've gotten that with xournal installed from nix-env before). Or could be that we need to wrap with |
andrew-d
force-pushed
the
adunham/xournalpp
branch
from
c585592
to
dd05c2c
Compare
andrew-d
force-pushed
the
adunham/xournalpp
branch
from
dd05c2c
to
0f9d0b2
Compare
flokli
reviewed
Mar 4, 2019
andrew-d
force-pushed
the
adunham/xournalpp
branch
from
0f9d0b2
to
7ac9599
Compare
andrew-d
force-pushed
the
adunham/xournalpp
branch
from
7ac9599
to
4cf0343
Compare
|
Thank you! 😃
…On Wed, Mar 6, 2019 at 1:28 AM Florian Klink ***@***.***> wrote:
Merged #56748 <#56748> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#56748 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABB3hYk7yJPP-VUlH0A_tVy5ZSm85a7pks5vT4pVgaJpZM4bavJQ>
.
|
|
Thank you :-) 19.03 backport in fab1780. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Closes #56470
Things done
sandboxinnix.confon non-NixOS)Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)Tested compilation of all pkgs that depend on this change usingnix-shell -p nox --run "nox-review wip"./result/bin/)Determined the impact on package closure size (by runningnix path-info -Sbefore and after)cc @luzpaz @dotlambda