Skip to content

xournalpp: init at 1.0.8 #56748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2019
Merged

xournalpp: init at 1.0.8 #56748

merged 1 commit into from
Mar 6, 2019

Conversation

andrew-d
Copy link
Contributor

@andrew-d andrew-d commented Mar 3, 2019

Motivation for this change

Closes #56470

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @luzpaz @dotlambda

Sorry, something went wrong.

@andrew-d andrew-d force-pushed the adunham/xournalpp branch from 50c0633 to 85e641d Compare March 3, 2019 02:36
@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 3, 2019
@hedning
Copy link
Contributor

hedning commented Mar 3, 2019

Runs and works with my wacom tablet in gnome on wayland 👍

@andrew-d andrew-d force-pushed the adunham/xournalpp branch 2 times, most recently from afa04bb to c585592 Compare March 3, 2019 20:28
@flokli
Copy link
Contributor

flokli commented Mar 3, 2019

@hedning did you see the tool icons? For me, a lot of them are missing…

@hedning
Copy link
Contributor

hedning commented Mar 3, 2019

Yeah, I've got icons. Might be some version mismatch or something (I've gotten that with xournal installed from nix-env before).

Or could be that we need to wrap with wrapGAppsHook (I installed it, though I'm IIRC the icons worked when running directly from results/bin too).

@andrew-d andrew-d force-pushed the adunham/xournalpp branch from c585592 to dd05c2c Compare March 4, 2019 01:48
@andrew-d
Copy link
Contributor Author

andrew-d commented Mar 4, 2019

@flokli - I think this may be some of the issues mentioned in #43150 - I switched to wrapGAppsHook and explicitly specified the hicolor-icon-theme buildInput. Try now?

@andrew-d andrew-d force-pushed the adunham/xournalpp branch from dd05c2c to 0f9d0b2 Compare March 4, 2019 01:50
@andrew-d andrew-d force-pushed the adunham/xournalpp branch from 0f9d0b2 to 7ac9599 Compare March 5, 2019 07:45
@andrew-d andrew-d force-pushed the adunham/xournalpp branch from 7ac9599 to 4cf0343 Compare March 5, 2019 07:46
@flokli flokli merged commit 6fb8b38 into NixOS:master Mar 6, 2019
@andrew-d
Copy link
Contributor Author

andrew-d commented Mar 6, 2019 via email

@flokli
Copy link
Contributor

flokli commented Mar 6, 2019

Thank you :-)

19.03 backport in fab1780.

@andrew-d andrew-d deleted the adunham/xournalpp branch March 9, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants