Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gohufont: 2.0 -> 2.1 #56707

Merged
merged 1 commit into from Mar 27, 2019
Merged

gohufont: 2.0 -> 2.1 #56707

merged 1 commit into from Mar 27, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Mar 2, 2019

Motivation for this change

#35003

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested in X.org and linux framebuffer
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files (none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

notes: the 2x scaled fonts can't be properly converted to pcf and entirely to psf. It appears to be a problem with the font itself as two different tools are giving the same result.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 3, 2019

Uhm, this is bad. ofBorg, my computer and a different one produced 3 different hashes.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 4, 2019

Ok, it was gzip fault but it's fixed now.

@xeji
Copy link
Contributor

xeji commented Mar 8, 2019

let's try again
@GrahamcOfBorg build gohufont

@xeji
Copy link
Contributor

xeji commented Mar 8, 2019

hash mismatch on all platforms, which I can reproduce locally for x86_64-linux.

xeji
xeji suggested changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix hash mismatch

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 8, 2019

Argh, it must be still nondeterministic: on my machine I can build it with this hash.
I don't know what else to do.

@xeji
Copy link
Contributor

xeji commented Mar 8, 2019

Maybe there's a way to build entirely from github?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 8, 2019

Not yet, until the issue regarding the font size is fixed.
Anyway I bet it's gzip again. I'll try to not compress the pcf fonts.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 12, 2019

@GrahamcOfBorg build gohufont

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 12, 2019

@GrahamcOfBorg build gohufont

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 13, 2019 •
edited

I removed the gzipping part and it seems reproducible now.
I don't understand why: there are many fixed-output derivations using gzip, so it's supposedly deterministic... unless there is a bug triggered by these particular files.
Debian reported this issue in the past but it has been fixed, maybe it's a new incarnation of it.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 27, 2019

ping

@7c6f434c 7c6f434c merged commit 7205c1e into NixOS:master Mar 27, 2019
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 27, 2019

Thank you.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 27, 2019

@7c6f434c can you close #35003?

@rnhmjoj rnhmjoj deleted the gohu branch September 14, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rnhmjoj @xeji @7c6f434c @GrahamcOfBorg