Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trash-cli and meld's checkPhase after #53440 #56705

Closed
wants to merge 2 commits into from

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Mar 2, 2019

Motivation for this change

Fix trash-cli and meld after #53440

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Needs some more inputs after checkInputs went native.
@hedning hedning added 9.needs: port to stable A PR needs a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 2, 2019
@xeji
Copy link
Contributor

xeji commented Mar 4, 2019

trash-cli was fixed in #56818, hence the merge conflict.

@aexoxea
Copy link

aexoxea commented Mar 18, 2019

Ping! I'd like to ask if we can progress the meld part of this PR please 😄 (noting that all checks are good and one reviewer has given the OK)?

@xeji
Copy link
Contributor

xeji commented Mar 18, 2019

I cherry-picked the meld part to master in 4a75888.
Closing this now as trash-cli was already fixed.

@xeji xeji closed this Mar 18, 2019
@xeji
Copy link
Contributor

xeji commented Mar 18, 2019

also backported the meld fix to 19.03 in 6a0bc21 /cc #56826

@hedning hedning deleted the fix-various-checkphase branch October 15, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants