Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyqt4: fix nativeBuildInputs #56770

Closed
wants to merge 1 commit into from
Closed

pyqt4: fix nativeBuildInputs #56770

wants to merge 1 commit into from

Conversation

f--t
Copy link
Contributor

@f--t f--t commented Mar 3, 2019

Motivation for this change

fixes the broken build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@f--t f--t requested a review from FRidh as a code owner March 3, 2019 07:19
@FRidh FRidh self-assigned this Mar 3, 2019
@FRidh
Copy link
Member

FRidh commented Mar 3, 2019

Duplicates #56717

@FRidh FRidh closed this Mar 3, 2019
@f--t f--t deleted the fix/pyqt4-build branch October 20, 2019 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@f--t @FRidh @GrahamcOfBorg