Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/rpy2 build #56769

Closed
wants to merge 2 commits into from
Closed

Fix/rpy2 build #56769

wants to merge 2 commits into from

Conversation

f--t
Copy link
Contributor

@f--t f--t commented Mar 3, 2019

Motivation for this change

The package wouldn't build because R was in buildInputs instead of nativeBuildInputs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Mar 3, 2019

pyqt4 commit duplicates another PR

@f--t
Copy link
Contributor Author

f--t commented Mar 3, 2019

duplicate merged.

@f--t f--t closed this Mar 3, 2019
@f--t f--t deleted the fix/rpy2-build branch October 20, 2019 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants