New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codechange: Sort and filter sign names directly rather than through string system. #7304
Conversation
…mal strings to start with.
Probably need to handle if Sign::name is null. |
This is now a fairly major improvement when a lot of signs are placed, and signs are added/remove regularly. This is not a normal situation but is achievable with debug options on some AIs (AIAI in this case).
|
This makes me wonder how much performance gain could be had by (somehow) optimising the entire FormatString flow. |
Using FormatString once will still needlessly (for the purposes of sorting/filtering) duplicate each string, but it may help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, but 6 commits looks like a lot, perhaps some of them should be merged together?
Closes #7303 |
…tring system. (OpenTTD#7304) This provides a notable performance benefit in the Sign List window when there are many signs.
…tring system. (OpenTTD#7304) This provides a notable performance benefit in the Sign List window when there are many signs.
No description provided.