Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sublime3: add updateScript #56730

Merged
merged 2 commits into from Mar 5, 2019
Merged

sublime3: add updateScript #56730

merged 2 commits into from Mar 5, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 2, 2019 •
edited

Motivation for this change

I extended our update-source-version utility and now we can update Sublime with update.nix.

cc @wmertens @demin-dmitriy @zimbatm (Sublime)
cc @dezgeg (common-updater-scripts)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
common-updater-scripts: Add file and system flags
0105058 
You can now optionally invoke update-source-versions with:

* --system flag changing the host platform, to be passed dirrectly to Nix commands.
  This is useful for binary packages which have different sources for each platform.
* --file flag allowing to change the file to be modified. This is useful for packages
  that offer multiple variants, listed in a different file than the derivation itself;
  e.g. packages.nix of Sublime Text 3.
* --version-key, which is now a keyword flag instead of a positional argument.
@jtojnar
sublime3: Add updateScript
a5cdac3
@jtojnar jtojnar merged commit 20ab640 into NixOS:master Mar 5, 2019
@jtojnar jtojnar deleted the sublime3-updatescript branch March 5, 2019 23:14
@jtojnar jtojnar added the 6.topic: updaters Tooling for (semi-)automated updating of packages label Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

@wmertens wmertens Awaiting requested review from wmertens

Assignees
No one assigned
Labels
6.topic: updaters Tooling for (semi-)automated updating of packages 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @GrahamcOfBorg