Fix #7307: Add WaterClass to MP_TREES #7309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
reviewed
Mar 2, 2019
|
Why do trees need a water class? |
|
Because trees can be on the shore, and that switches the tile type to MP_TREES. Those "trees on shore" should be detected as sea by anything that cares. |
|
Can you please update landscape.html and landscape_grid.html? |
Eddi-z
force-pushed
the
treewater
branch
2 times, most recently
from
6609620
to
fae9b57
Compare
PeterN
approved these changes
Mar 2, 2019
nielsmh
pushed a commit
to nielsmh/OpenTTD
that referenced
this pull request
Mar 11, 2019
…oast tiles (OpenTTD#7309) This allows allows NewGRF object/industry placement rules to treat trees on coast tiles the same as regular bare coast.
PeterN
added a commit
to PeterN/OpenTTD
that referenced
this pull request
Mar 24, 2019
…are on coast tiles (OpenTTD#7309)" This reverts commit b242a04.
douiwby
pushed a commit
to douiwby/OpenTTD
that referenced
this pull request
Apr 16, 2020
…oast tiles (OpenTTD#7309) This allows allows NewGRF object/industry placement rules to treat trees on coast tiles the same as regular bare coast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression seems to fail on some money changes (maybe unwanted side effects?)