-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
bazel: 0.22.0 -> 0.23.0 #56587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: 0.22.0 -> 0.23.0 #56587
Conversation
@GrahamcOfBorg build bazel.tests |
1 similar comment
@GrahamcOfBorg build bazel.tests |
Hm, do you know where the darwin failure could come from? @uri-canva, can you take a look? |
Not sure, the error message isn't very helpful, and it works locally without sandbox, and I could never get it to work locally with sandbox enabled in the first place. Sorry. |
Can you try enabling the sandbox and see whether it builds locally? |
No I mean I can't build the derivation with sandbox enabled even without this patch. |
If you check out a5aca72 (update to 0.22), you can download bazel 0.22 from the darwin binary cache, so I assume it did work with sandbox enabled before this PR. |
@@ -61,7 +61,7 @@ let | |||
in | |||
stdenv.mkDerivation rec { | |||
|
|||
version = "0.22.0"; | |||
version = "0.23.0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.23.1
was released 3 days ago.
Yeah it definitely does on hydra, but on my laptop I get a completely different error, and it's the same error with or without this PR. I've had that error since the first time I tried the Bazel derivation, on both of my laptops so I didn't spend any further time trying to fix it. It's very hard to debug the hydra in those rare situations where building with sandbox locally doesn't behave the same. I hit the same issue on |
obsoleted by #58147, which was merged. |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)