Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: 0.22.0 -> 0.23.0 #56587

Closed
wants to merge 1 commit into from
Closed

bazel: 0.22.0 -> 0.23.0 #56587

wants to merge 1 commit into from

Conversation

dgarzon
Copy link
Contributor

@dgarzon dgarzon commented Mar 1, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Profpatsch
Copy link
Member

@GrahamcOfBorg build bazel.tests

1 similar comment
@Profpatsch
Copy link
Member

@GrahamcOfBorg build bazel.tests

@Profpatsch
Copy link
Member

Hm, do you know where the darwin failure could come from? @uri-canva, can you take a look?

@uri-canva
Copy link
Contributor

Not sure, the error message isn't very helpful, and it works locally without sandbox, and I could never get it to work locally with sandbox enabled in the first place. Sorry.

@Profpatsch
Copy link
Member

Profpatsch commented Mar 7, 2019

and I could never get it to work locally with sandbox enabled in the first place. Sorry.

Can you try enabling the sandbox and see whether it builds locally?

@uri-canva
Copy link
Contributor

No I mean I can't build the derivation with sandbox enabled even without this patch.

@Profpatsch
Copy link
Member

No I mean I can't build the derivation with sandbox enabled even without this patch.

If you check out a5aca72 (update to 0.22), you can download bazel 0.22 from the darwin binary cache, so I assume it did work with sandbox enabled before this PR.

@@ -61,7 +61,7 @@ let
in
stdenv.mkDerivation rec {

version = "0.22.0";
version = "0.23.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.23.1 was released 3 days ago.

@uri-canva
Copy link
Contributor

If you check out a5aca72 (update to 0.22), you can download bazel 0.22 from the darwin binary cache, so I assume it did work with sandbox enabled before this PR.

Yeah it definitely does on hydra, but on my laptop I get a completely different error, and it's the same error with or without this PR. I've had that error since the first time I tried the Bazel derivation, on both of my laptops so I didn't spend any further time trying to fix it.

It's very hard to debug the hydra in those rare situations where building with sandbox locally doesn't behave the same. I hit the same issue on bazel-remote. 😢

@flokli
Copy link
Contributor

flokli commented Apr 3, 2019

obsoleted by #58147, which was merged.

@flokli flokli closed this Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants