Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages.contribs.zorn-lemmas: 8.6.0 -> 8.8.0 #56588

Closed
wants to merge 1 commit into from
Closed

coqPackages.contribs.zorn-lemmas: 8.6.0 -> 8.8.0 #56588

wants to merge 1 commit into from

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Mar 1, 2019

Update zorn-lemmas Coq package. This is untested for now.

@Zimmi48 Zimmi48 marked this pull request as ready for review March 2, 2019 17:20
@Zimmi48
Copy link
Member Author

Zimmi48 commented Mar 2, 2019

Now tested with Coq 8.6 -> 8.9. However, the version number is fake because no version compatible with Coq 8.9 has been tagged yet. So maybe we should wait on this before merging.

BTW, I think the contribs attribute set should be reexported as part of coqPackages as I did when introducing the janeStreet attribute set in ocamlPackages (see https://github.com/NixOS/nixpkgs/pull/25658/files#diff-10ffb37397df96f7c25aff8aaecefd78R876). WDYT @vbgl? That being said, contribs that are kept up-to-date with recent Coq versions are slowly being moved to coq-community (which also includes packages that were not contribs previously) so maybe we should just split these packages out of the contribs attribute set one by one.

@vbgl
Copy link
Contributor

vbgl commented Mar 11, 2019

@GrahamcOfBorg build coqPackages.contribs.zorn-lemmas

@vbgl
Copy link
Contributor

vbgl commented Mar 11, 2019

@GrahamcOfBorg build coqPackages.contribs.zorns-lemma

@Zimmi48 There is a typo in the commit message ;-)

@vbgl
Copy link
Contributor

vbgl commented Mar 12, 2019

Cherry-picked into master as b6a6f7a.

@vbgl vbgl closed this Mar 12, 2019
@Zimmi48 Zimmi48 deleted the update-zorn-lemmas branch April 26, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: coq 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zimmi48 @vbgl @GrahamcOfBorg