Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add screen orientation test: fire event before promise is resolved #15267

Merged
merged 5 commits into from Feb 12, 2019
Merged

Add screen orientation test: fire event before promise is resolved #15267

merged 5 commits into from Feb 12, 2019

Conversation

Johanna-hub
Copy link
Contributor

@Johanna-hub Johanna-hub commented Feb 6, 2019 •
edited by marcoscaceres

@marcoscaceres marcoscaceres changed the title Add screen orientation test: fireevent before promise is resolved Add screen orientation test: fire event before promise is resolved Feb 7, 2019
@Johanna-hub Johanna-hub mentioned this pull request Feb 7, 2019
Merged
5 tasks
marcoscaceres
marcoscaceres reviewed Feb 7, 2019
View reviewed changes
Copy link
Contributor

@marcoscaceres marcoscaceres left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take what you learned from this test and see if you can apply the same to any other tests.

marcoscaceres and others added 2 commits February 12, 2019 11:55
@marcoscaceres @Johanna-hub
Update screen-orientation/event-before-promise.html
6acae67 
Co-Authored-By: Johanna-hub <Johanna-hub@users.noreply.github.com>
@marcoscaceres @Johanna-hub
Update screen-orientation/event-before-promise.html
f044cda 
Co-Authored-By: Johanna-hub <Johanna-hub@users.noreply.github.com>
@marcoscaceres marcoscaceres merged commit 8ed6468 into web-platform-tests:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

@haoxli haoxli Awaiting requested review from haoxli

Assignees

@marcoscaceres marcoscaceres

Labels
screen-orientation wg-webplatform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Johanna-hub @marcoscaceres @wpt-pr-bot