Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitkraken: 4.2.1 -> 4.2.2 & fix missing gsettings schemas #55308

Merged
merged 4 commits into from Feb 26, 2019
Merged

gitkraken: 4.2.1 -> 4.2.2 & fix missing gsettings schemas #55308

merged 4 commits into from Feb 26, 2019

Conversation

megheaiulian
Copy link
Contributor

@megheaiulian megheaiulian commented Feb 6, 2019 •
edited

Motivation for this change

Update gitkraken 4.2.1 to 4.2.2
Fix gitkraken missing GSettings schemas

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@megheaiulian megheaiulian changed the title gitkraken: fix missing gsettings schemas gitkraken: 4.2.1 -> 4.2.2 & fix missing gsettings schemas Feb 9, 2019
@megheaiulian
Copy link
Contributor Author

@worldofpeace Thank you for the feedback. I've updated the PR.

@megheaiulian
Copy link
Contributor Author

@Mic92 @worldofpeace Can someone check this again ?

@Mic92 Mic92 merged commit 8aa3422 into NixOS:master Feb 26, 2019
@megheaiulian megheaiulian deleted the feature/gitraken-gsettings branch March 14, 2019 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@megheaiulian @Mic92 @worldofpeace @GrahamcOfBorg