Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checkPhase for neovim (disabled by default) #55266

Merged
merged 5 commits into from Feb 5, 2019
Merged

Add checkPhase for neovim (disabled by default) #55266

merged 5 commits into from Feb 5, 2019

Conversation

teto
Copy link
Member

@teto teto commented Feb 5, 2019 •
edited

Motivation for this change

and some other minor changes

The new lua infrastructure makes available the necessary lua packages to run the neovim tests. Yet some tests still fail and I don't think they are intended for distributions to run anyway so I let them disabled by default.
They are helpful for neovim developers though !

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto teto changed the title Enable functionaltests for neovim Add checkPhase for neovim (disabled by default) Feb 5, 2019
@teto teto mentioned this pull request Feb 5, 2019
Closed
10 tasks
@teto
Copy link
Member Author

teto commented Feb 5, 2019

CC @7c6f434c

@7c6f434c 7c6f434c merged commit aaeaa6d into NixOS:master Feb 5, 2019
@teto teto deleted the lua_merge branch February 5, 2019 15:12
@teto teto mentioned this pull request Feb 6, 2019
Closed
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garbas garbas Awaiting requested review from garbas

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teto @7c6f434c @GrahamcOfBorg