Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixopsUnstable: 1.6.1pre2706_d5ad09c -> 1.6.1pre2728_8ed39f9 #55338

Merged
merged 1 commit into from Feb 6, 2019
Merged

nixopsUnstable: 1.6.1pre2706_d5ad09c -> 1.6.1pre2728_8ed39f9 #55338

merged 1 commit into from Feb 6, 2019

Conversation

erictapen
Copy link
Member

Motivation for this change

This fixes evaluation with the latest master. See also NixOS/nixops#1086 and NixOS/nixops#1088 for this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen
nixopsUnstable: 1.6.1pre2706_d5ad09c -> 1.6.1pre2728_8ed39f9
37c3ab8 
This fixes evaluation with the latest master. See also [0] and [1] for
this.

[0] NixOS/nixops#1086
[1] NixOS/nixops#1088
@worldofpeace
Copy link
Contributor

Thanks @erictapen I was meaning to do this as well 👍

worldofpeace
worldofpeace approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed lots of machines successfully with this already.

@worldofpeace worldofpeace merged commit c02cfc6 into NixOS:master Feb 6, 2019
@erictapen erictapen deleted the nixops-8ed39f9 branch February 6, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erictapen @worldofpeace @GrahamcOfBorg