apvlv: fix build for poppler 0.73.0 #55337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build apvlv |
|
Related issue #54021 |
|
@teto Thanks for the link, didn't see that. |
erictapen
force-pushed
the
apvlv-poppler
branch
from
0dbd351
to
808b4cf
Compare
Poppler was upgraded in [0] and therefore the build broke, as poppler/goo/gtypes.h was moved into poppler/goo/gfile.h [1]. Upstream issue is [2]. [0] NixOS@7757e43 [1] https://gitlab.freedesktop.org/poppler/poppler/commit/ef3ef702bc3dc845731e43215400448c5324efd4 [2] naihe2010/apvlv#28
erictapen
force-pushed
the
apvlv-poppler
branch
from
808b4cf
to
29ba80c
Compare
worldofpeace
reviewed
Feb 6, 2019
| @@ -43,6 +43,12 @@ stdenv.mkDerivation rec { | |||
| }) | |||
| ]; | |||
|
|
|||
| # poppler 0.73.0 moved functionality from gtypes.h into gfile.h | |||
| postPatch = '' | |||
| grep -rlF '#include "goo/gtypes.h"' | xargs sed -i 's|#include "goo/gtypes.h"|#include "goo/gfile.h"|g' | |||
There was a problem hiding this comment.
The only one that matters here is https://github.com/naihe2010/apvlv/blob/41f68a9640dcf2c179567a7e8c8d3d0552ece584/src/ApvlvPdf.cc#L32
So a patch would be safer.
I conveniently have a patch lying around for this, if you'd like to include it
worldofpeace@1d34b85
There was a problem hiding this comment.
Your solution looks more convenient indeed. I'll provide a new PR with your patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
apvlvdoesn't build on master.Pinging maintainer @ardumont
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)