New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.python-jenkins: 1.3.0 -> 1.4.0 #55340
Conversation
4cae9bf
to
b4e6200
Compare
So using the source at https://git.openstack.org/cgit/openstack/python-jenkins doesn't work? |
I used the GitHub version (https://github.com/openstack/python-jenkins/) using |
@worldofpeace anything else to add? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and is probably fine, last thing you could do to check would be to maybe run the tests locally.
Updates to the most recent version of `python-jenkins`. It was originally broken during the auto-update in b4588c6. The tests could be run by using `unittest2` and some dependencies for the test framwork.
b4e6200
to
fb79b89
Compare
@worldofpeace I retried and managed to get the tests running :) |
Noticed that you didn't pull in all the deps Though I did see some warnings when the tests were running
|
Yeah. Upstream put several development tools into
The code yields warnings if extra headers for Jenkins requests are set. If I understand the code right, this happens in some testcases and is actually fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take 2 :) and tests pass fine 👍
Motivation for this change
Updates to the most recent version of
python-jenkins
. It wasoriginally broken during the auto-update in b4588c6.
The tests could be run by using
unittest2
and some dependencies forthe test framwork.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)