Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tinycdb: init at 0.7.8 #55279

Merged
merged 1 commit into from Mar 10, 2020
Merged

tinycdb: init at 0.7.8 #55279

merged 1 commit into from Mar 10, 2020

Conversation

KAction
Copy link
Contributor

@KAction KAction commented Feb 5, 2019

  • [+] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • [+] other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [+] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • [+] Fits CONTRIBUTING.md.

@KAction
Copy link
Contributor Author

KAction commented Feb 5, 2019

Push-forced fix of license

@KAction
Copy link
Contributor Author

KAction commented Feb 6, 2019

Sorry. Did not get it. What more should I change?

@ryantm
Copy link
Member

ryantm commented Jan 4, 2020

@KAction Sorry no one followed up. I think they are saying you should remove the line outputsToInstall = outputs;

ryantm
ryantm requested changes Jan 4, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since the package is called "tinycbd", so the commit message should be "tinycbd: init at..."

pkgs/development/libraries/tinycdb/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/tinycdb/default.nix Outdated Show resolved Hide resolved
@ryantm ryantm changed the title libcdb: init at 0.7.8 tinycbd: init at 0.7.8 Mar 8, 2020
@ryantm
Copy link
Member

ryantm commented Mar 9, 2020

@GrahamcOfBorg build tinycbd

@ryantm ryantm changed the title tinycbd: init at 0.7.8 tinycdb: init at 0.7.8 Mar 9, 2020
@ryantm
Copy link
Member

ryantm commented Mar 9, 2020

@GrahamcOfBorg build tinycdb

ryantm
ryantm requested changes Mar 9, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't build on darwin so we need to mark it linux only or fix it on darwin.

@KAction
Copy link
Contributor Author

KAction commented Mar 10, 2020

@ryantm Marked as platforms.linux.

@ryantm ryantm merged commit 5d6cdc6 into NixOS:master Mar 10, 2020
@KAction KAction deleted the libcdb branch October 29, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien left review comments

@ryantm ryantm ryantm requested changes

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KAction @ryantm @aanderse @symphorien @GrahamcOfBorg