New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.notedown: init at 1.5.1 #55284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to use stdenv
, just use lib
.
Also, please make sure to add appropriate checkPhase
s or, if there are no tests, set doCheck = false
and add a comment with the reason.
I forgot to mention: please make sure to have exactly three commits: the first one should add yourself as a maintainer and the two others are for the two packages. |
The package itself seems fine now, I have two questions though:
|
@Ma27 Warning is removed after adding |
Are there any updates on this pull request, please? |
pythonPackages.notedown: init at 1.5.1 (cherry picked from commit 38929d3)
Motivation for this change
Add notedown to nixpkgs
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)