Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.notedown: init at 1.5.1 #55284

Merged
merged 3 commits into from Jan 5, 2020
Merged

Conversation

vcanadi
Copy link
Contributor

@vcanadi vcanadi commented Feb 5, 2019

Motivation for this change

Add notedown to nixpkgs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to use stdenv, just use lib.

Also, please make sure to add appropriate checkPhases or, if there are no tests, set doCheck = false and add a comment with the reason.

@dotlambda
Copy link
Member

I forgot to mention: please make sure to have exactly three commits: the first one should add yourself as a maintainer and the two others are for the two packages.

@Ma27
Copy link
Member

Ma27 commented Feb 10, 2019

The package itself seems fine now, I have two questions though:

  • nix-build -A pythonPackages.notedown works fine, but python.withPackages (ps: with ps; [ notedown ]) fails with the following error:

    these derivations will be built:
      /nix/store/slgls8y80s9v69pny5dv372zjdva298b-python-2.7.15-env.drv
    building '/nix/store/slgls8y80s9v69pny5dv372zjdva298b-python-2.7.15-env.drv'...
    collision between `/nix/store/4hi6nipj7x4kml0cl0lg1p5giw13ym1f-python2.7-backports.shutil_get_terminal_size-unstable-2016-02-21/lib/python2.7/site-packages/backports/__init__.pyc' and `/nix/store/bibs4wix1jlnj29b6b49ac4wvfmc22m0-python2.7-configparser-3.5.0/lib/python2.7/site-packages/backports/__init__.pyc'
    builder for '/nix/store/slgls8y80s9v69pny5dv372zjdva298b-python-2.7.15-env.drv' failed with exit code 25
    error: build of '/nix/store/slgls8y80s9v69pny5dv372zjdva298b-python-2.7.15-env.drv' failed
    
  • When importing notedown in a python3 environment I get the following warning (the module works perfectly fine):

    >>> import notedown
    /nix/store/1aagq246as0xvnphsw858r5lpgcv645r-python3-3.7.2-env/lib/python3.7/site-packages/IPython/html.py:14: ShimWarning: The `IPython.html` package has been deprecated since IPython 4.0. You should import from `notebook` instead. `IPython.html.widgets` has moved to `ipywidgets`.
      "`IPython.html.widgets` has moved to `ipywidgets`.", ShimWarning)
    

    I assume this is just because of a dependency of notedown, right? Or is that fixable here as well?

@vcanadi
Copy link
Contributor Author

vcanadi commented Feb 14, 2019

@Ma27 Warning is removed after adding notebook to propagated build inputs. I don't know why withPackages approach is causing collisions for python 2.7.

@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

Are there any updates on this pull request, please?

@ryantm ryantm merged commit 38929d3 into NixOS:master Jan 5, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 6, 2020
 pythonPackages.notedown: init at 1.5.1

(cherry picked from commit 38929d3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants