Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redmine: 3.4.8 -> 4.0.1 #55234

Merged
merged 8 commits into from Feb 5, 2019
Merged

redmine: 3.4.8 -> 4.0.1 #55234

merged 8 commits into from Feb 5, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Feb 4, 2019

Motivation for this change

Include Redmine 4.x series in NixOS, while maintaining the 3.4.x series. The 4.x series is very new and not necessarily something people will want to be upgrading to immediately. The 3.4.x series is still maintained upstream and receiving security patches. With this commit existing Redmine users can choose to upgrade to the 4.x series at their convenience, after they have been able to test in house to make sure compatibility with all of their plugins and settings.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

aanderse commented Feb 4, 2019

@GrahamcOfBorg build redmine_4

@aanderse
Copy link
Member Author

aanderse commented Feb 4, 2019

@GrahamcOfBorg test redmine

@aanderse
Copy link
Member Author

aanderse commented Feb 5, 2019

I ran the redmine tests locally and they passed. I'm not sure why the tests didn't run properly here. Any ideas?

@7c6f434c and @Ekleog looking for any feedback on this PR, and a bonus if you know why @GrahamcOfBorg isn't evaluating my redmine test.

@7c6f434c
Copy link
Member

7c6f434c commented Feb 5, 2019

@GrahamcOfBorg test redmine

@7c6f434c
Copy link
Member

7c6f434c commented Feb 5, 2019

@GrahamcOfBorg build nixosTests.redmine

@7c6f434c
Copy link
Member

7c6f434c commented Feb 5, 2019

@aanderse are you an extra-known-user for ofborg?

@aanderse
Copy link
Member Author

aanderse commented Feb 5, 2019

@aanderse are you an extra-known-user for ofborg?

https://github.com/NixOS/ofborg/blob/c17ef84004073cea718f21c1605e2242d7b3e4c0/config.extra-known-users.json#L2
Yes.

@aanderse
Copy link
Member Author

aanderse commented Feb 5, 2019

@GrahamcOfBorg test redmine

Notice the test says success but clicking more details doesn't show anything meaningful (to me).

https://github.com/NixOS/nixpkgs/pull/55234/checks?check_run_id=58937573

@7c6f434c
Copy link
Member

7c6f434c commented Feb 5, 2019

That's true and that is why I tried to run the test via nixosTests

@7c6f434c
Copy link
Member

7c6f434c commented Feb 5, 2019

O-o-o-K, Aarch64 seems to succeed with tests…

@7c6f434c 7c6f434c merged commit b8a9c3f into NixOS:master Feb 5, 2019
@aanderse aanderse deleted the redmine-4.x branch February 5, 2019 12:07
@aanderse
Copy link
Member Author

aanderse commented Feb 5, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

@garbas garbas Awaiting requested review from garbas

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @7c6f434c @GrahamcOfBorg