Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since 2.3, NCCL 2 is released under BSD 3-Clause and can be built from source.
I have defined
nccl_cudatoolkit_9_0
,9
(currently 9.2) and10
because these are the builds available at https://developer.nvidia.com/nccl/nccl-download (requires a free nvidia.com account). I have removednccl_cudatoolkit_8
, because although NCCL might be buildable with CUDA 8.0,cudatoolkit_8
is broken in Nixpkgs.Things done
sandbox
innix.conf
on non-NixOS)nix-reviewnix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)--
/cc @abbradar who has changed the maintainer from @hyphon81 to @mdaiter in 41abde9