Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] lua: Add more packages from a generated source #55263

Closed
wants to merge 15 commits into from

Conversation

teto
Copy link
Member

@teto teto commented Feb 5, 2019

DO NOT MERGE

I push this to not lose the history as long as to prevent duplicate work if anyone wants to go that way.

This was removed to ease merging, let's put it back once the lua ecosystem stabilizes.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto teto mentioned this pull request Feb 13, 2019
10 tasks
@alyssais alyssais changed the title DO NOT MERGE lua: Add more packages from a generated source [WIP] lua: Add more packages from a generated source Feb 22, 2019
@grahamc
Copy link
Member

grahamc commented Apr 12, 2019

@GrahamcOfBorg eval

@teto
Copy link
Member Author

teto commented Jun 5, 2019

almost all of them have been converted already (zlib/expat/cjson soon). closing.

@teto teto closed this Jun 5, 2019
@teto teto deleted the lua_increase_whitelist branch July 12, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants