Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dovecot: 2.3.4 -> 2.3.4.1 #55343

Merged
merged 1 commit into from Feb 7, 2019
Merged

dovecot: 2.3.4 -> 2.3.4.1 #55343

merged 1 commit into from Feb 7, 2019

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Feb 6, 2019 •
edited

Motivation for this change

fixes CVE-2019-3814: https://dovecot.org/list/dovecot-news/2019-February/000394.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Should we update our Dovecot version on release-18.09 from 2.3.2.1 to 2.3.4.1 or only apply an appropriate patch?

@dotlambda dotlambda added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Feb 6, 2019
peti
peti approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update. It's 👍 for master.

As far as release-18.09 is concerned, I'd prefer a back-port of only the relevant patch if that is doable with a reasonable amount of effort.

@dotlambda dotlambda mentioned this pull request Feb 6, 2019
Merged
10 tasks
@fpletz fpletz merged commit fe6d15e into NixOS:master Feb 7, 2019
@dotlambda dotlambda deleted the dovecot-2.3.4.1 branch March 21, 2019 09:32
@TredwellGit TredwellGit removed the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti approved these changes

@fpletz fpletz fpletz approved these changes

@rickynils rickynils Awaiting requested review from rickynils

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dotlambda @peti @fpletz @GrahamcOfBorg @TredwellGit