Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins: init vim-prettier #55242

Closed
wants to merge 1 commit into from
Closed

vimPlugins: init vim-prettier #55242

wants to merge 1 commit into from

Conversation

zachcoyle
Copy link
Contributor

@zachcoyle zachcoyle commented Feb 5, 2019 •
edited

Motivation for this change

This change adds the vim-prettier formatter plugin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zachcoyle zachcoyle changed the title vimPlugins: init prettier vimPlugins: init vim-prettier Feb 5, 2019
@dtzWill
Copy link
Member

dtzWill commented Feb 5, 2019

Should this pull in the prettier tool automatically? Or is there a reason to not do so?

@zachcoyle
Copy link
Contributor Author

The prettier devs' recommendation is to use a version that is installed as part of a project's npm dependencies, as the formatting is not necessarily consistent between versions. That being said, I think that pulling it in here would be ideal as a fallback, but I'm not sure how to get prettier into the path from here.

@dtzWill
Copy link
Member

dtzWill commented Feb 5, 2019 via email

@zachcoyle
Copy link
Contributor Author

Closing this since I started using ALE instead. Might revisit this later

@zachcoyle zachcoyle closed this Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zachcoyle @dtzWill @GrahamcOfBorg