Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Both server and client crash, AI related #7188

Closed
SamuXarick opened this issue Feb 6, 2019 · 4 comments
Closed

Both server and client crash, AI related #7188

SamuXarick opened this issue Feb 6, 2019 · 4 comments
Labels
stale Stale issues

Comments

@SamuXarick
Copy link
Contributor

SamuXarick commented Feb 6, 2019 •
edited
Loading

Version of OpenTTD

2019-02-06-master-gbfdad9ad1b

Expected result

No crash

Actual result

Crash

Steps to reproduce

1 - on server, start multiplayer non-dedicated server game with 14 AIs set up, with 250000 #opcodes, build speed set to very fast, and a start_date of 0 on every AI.
2 - on client, join server as Spectator while not all companies have started yet.
3 - on server, open AI Debug Window, click Reload on one of the AIs. If it doesn't crash right away, try Reload on another AI, until one of them crashes.
4 - on client, a timeout of 20 seconds is displayed, then it crashes after that, I suppose when exiting to main menu, not sure.

crash.log
crash.log

2019-02-06 4
Left = server, Right = client
@SamuXarick
Copy link
Contributor Author

SamuXarick commented Feb 7, 2019 •
edited
Loading

[00:00] for the client crash, I think the problem is here at network_client.cpp line 1176 and 1174 should be switched
[00:01] CloseConnection makes _networking = false, and when the save occurs, it is already saving with no network
[00:01] there is no instance running on the client, only on the server
[00:01] should save empty

OpenTTD/src/network/network_client.cpp

Lines 1171 to 1178 in bfdad9a

/* 20 seconds are (way) more than 4 game days after which
* the server will forcefully disconnect you. */
if (lag > 20) {
this->NetworkGameSocketHandler::CloseConnection();
ShowErrorMessage(STR_NETWORK_ERROR_LOSTCONNECTION, INVALID_STRING_ID, WL_CRITICAL);
ClientNetworkEmergencySave();
return;
}

There are two emergency saves. Shouldn't 1 be enough? CloseConnection does an emergency save, then another is done after the error message. Is that the intention? Even the error message is repeated.

@glx22
Copy link
Contributor

glx22 commented Feb 7, 2019

4fb76db added the function, and the extra call it seems.

@glx22
Copy link
Contributor

glx22 commented Feb 7, 2019

And for the server crash, I think some test must be added to

OpenTTD/src/ai/ai_instance.cpp

Line 261 in bfdad9a

if (c == NULL || c->ai_instance == NULL) return;

SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Feb 7, 2019
@SamuXarick
Fix OpenTTD#7188: AI instance crash when reloading AI in a server, an…
8c84c72 
…d an AI save crash when doing an emergency network save.
@nielsmh nielsmh mentioned this issue Feb 28, 2019
Merged
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Mar 1, 2019
@SamuXarick
Fix OpenTTD#7188: AI instance crash when reloading AI in a server, an…
a78c06a 
…d an AI save crash when doing an emergency network save.
@TrueBrain TrueBrain mentioned this issue Mar 2, 2019
Closed
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Mar 4, 2019
@SamuXarick
Fix OpenTTD#7188: AI instance crash when reloading AI in a server.
ab8491c
@stale
Copy link

stale bot commented Apr 8, 2019

This issue has been automatically marked as stale because it has not had any activity in the last two months.
If you believe the issue is still relevant, please test on the latest nightly and report back.
It will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@stale stale bot added the stale Stale issues label Apr 8, 2019
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Apr 11, 2019
@SamuXarick
Fix OpenTTD#7188: AI instance crash when reloading AI in a server.
6f288ac
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Apr 13, 2019
@SamuXarick
Fix OpenTTD#7188: AI instance crash when reloading AI in a server.
7b67c07
@stale stale bot closed this as completed Apr 15, 2019
SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue Jul 18, 2019
@SamuXarick
Fix OpenTTD#7188: AI instance crash when reloading AI in a server.
a3c3c68
@nielsmh nielsmh mentioned this issue Sep 6, 2019
Merged
LordAro pushed a commit that referenced this issue Sep 7, 2019
@glx22 @LordAro
Fix #7188: check the validity of command callback for scripts (#7701)
b3fd787
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this issue Sep 7, 2019
@glx22 @nielsmh
Fix OpenTTD#7188: check the validity of command callback for scripts (O…
fc4ec15 
…penTTD#7701)
LordAro pushed a commit that referenced this issue Sep 7, 2019
@glx22 @LordAro
Fix #7188: check the validity of command callback for scripts (#7701)
6369e06
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@glx22 @douiwby
Fix OpenTTD#7188: check the validity of command callback for scripts (O…
022b434 
…penTTD#7701)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale Stale issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glx22 @SamuXarick