Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1525327] Don't crash wptrunner if mozversion fails #15271

Merged
merged 1 commit into from Feb 10, 2019

Conversation

moz-wptsync-bot
Copy link
Collaborator

On Android we aren't necessarily passing in the package path, so
mozversion can't extract the relevant metadata, and on other platforms
it could also fail if we pass in a script file or similar. In that
case we shouldn't fail.

Differential Revision: https://phabricator.services.mozilla.com/D18712

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1525327
gecko-commit: 9592b19c9b097e1a0136324cee3e8d54160a188e
gecko-integration-branch: central
gecko-reviewers: ato

@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Feb 6, 2019
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

On Android we aren't necessarily passing in the package path, so
mozversion can't extract the relevant metadata, and on other platforms
it could also fail if we pass in a script file or similar. In that
case we shouldn't fail.

Differential Revision: https://phabricator.services.mozilla.com/D18712

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1525327
gecko-commit: 6ab9304b1048371044dc8b56e1e6669334735cd6
gecko-integration-branch: central
gecko-reviewers: ato
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra mozilla:gecko-sync wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants