New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lxqt: 0.13.0 -> 0.14.0 #55365
lxqt: 0.13.0 -> 0.14.0 #55365
Conversation
@GrahamcOfBorg build lxqt.compton-conf lxqt.libfm-qt lxqt.liblxqt lxqt.libqtxdg lxqt.libsysstat lxqt.lximage-qt lxqt.lxqt-about lxqt.lxqt-admin lxqt.lxqt-build-tools lxqt.lxqt-config lxqt.lxqt-globalkeys lxqt.lxqt-notificationd lxqt.lxqt-openssh-askpass lxqt.lxqt-panel lxqt.lxqt-policykit lxqt.lxqt-powermanagement lxqt.lxqt-qtplugin lxqt.lxqt-runner lxqt.lxqt-session lxqt.lxqt-sudo lxqt.lxqt-themes lxqt.obconf-qt lxqt.pavucontrol-qt lxqt.pcmanfm-qt lxqt.qps lxqt.qterminal lxqt.qtermwidget lxqt.screengrab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw in a few expressions that patchPhase
was used directly and should be using postPatch
.
This can be a problem as it will prevent you from adding any patches.
Noticed also because of how they have their CMakeLists.txt set up, you have to add
substituteInPlace CMakeLists.txt \
--replace "\''${LXQT_TRANSLATIONS_DIR}" "''${out}/share/lxqt/translations"
to pretty much everything.
This is not a blocker to merge but it would be a nice improvement if we didn't have to do that.
Possibly open an issue upstream with possible solutions.
Additionally, I've noticed translations we're broken in Plasma. are they working here?
(possibly non-related issue)
Fixed. |
This may be handled later. |
In |
😄 Guess I didn't delete that comment after I realized you were doing Though I also noticed that you were using |
Other than that, this looks fine and I'm testing locally now. |
Fixed. |
Fixed. |
Motivation for this change
Update LXQt to version 0.14.0.
Release LXQt 0.14.0
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)