Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support for WorkletAnimation.playbackRate #14946

Merged
merged 1 commit into from Feb 11, 2019
Merged

Initial support for WorkletAnimation.playbackRate #14946

merged 1 commit into from Feb 11, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 18, 2019 •
edited

Changes for scroll-linked worklet animations will come in a separate pull request.

Bug: 852475
Change-Id: Ie6dd14242797cbc14a7e1e377f23c3dda174fe15
Reviewed-on: https://chromium-review.googlesource.com/c/1423537
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#628800}

wpt-pr-bot
wpt-pr-bot approved these changes Jan 18, 2019
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1423537 branch 2 times, most recently from daa59a2 to 2deae27 Compare January 29, 2019 23:31
@ogerchikov
Initial support for WorkletAnimation.playbackRate
59f1c95 
Changes for scroll-linked worklet animations will come in a separate pull request.

Bug: 852475
Change-Id: Ie6dd14242797cbc14a7e1e377f23c3dda174fe15
Reviewed-on: https://chromium-review.googlesource.com/c/1423537
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#628800}
@lukebjerring
Copy link
Contributor

Taskcluster error seems to be transient (complaining about not being able to find the window), so rebasing + force-pushing to retry.

@KyleJu
Copy link
Contributor

KyleJu commented Feb 5, 2019

Close this PR because the Chromium CL does not have exportable changes.

@KyleJu KyleJu closed this Feb 5, 2019
@KyleJu KyleJu deleted the chromium-export-cl-1423537 branch February 5, 2019 15:36
@KyleJu KyleJu restored the chromium-export-cl-1423537 branch February 6, 2019 23:12
@KyleJu KyleJu reopened this Feb 6, 2019
@foolip
Copy link
Member

foolip commented Feb 8, 2019

Taskcluster found this flakiness in Chrome Dev:

Test Subtest Results Messages
/animation-worklet/scroll-timeline-writing-modes.https.html A block ScrollTimeline should produce the correct current time for vertical-lr FAIL: 2/10, PASS: 8/10 assert_equals: expected "matrix(1, 0, 0, 1, 0, 50)" but got "matrix(1, 0, 0, 1, 0, 0)"
/animation-worklet/scroll-timeline-writing-modes.https.html A block ScrollTimeline should produce the correct current time for vertical-rl FAIL: 2/10, PASS: 8/10 assert_equals: expected "matrix(1, 0, 0, 1, 0, 50)" but got "matrix(1, 0, 0, 1, 0, 0)"
/animation-worklet/scroll-timeline-writing-modes.https.html An inline ScrollTimeline should produce the correct current time for horizontal-tb and direction: rtl FAIL: 2/10, PASS: 8/10 assert_equals: expected "matrix(1, 0, 0, 1, 0, 50)" but got "matrix(1, 0, 0, 1, 0, 0)"
/animation-worklet/scroll-timeline-writing-modes.https.html An inline ScrollTimeline should produce the correct current time for vertical writing mode FAIL: 2/10, PASS: 8/10 assert_equals: expected "matrix(1, 0, 0, 1, 0, 50)" but got "matrix(1, 0, 0, 1, 0, 0)"
/animation-worklet/scroll-timeline-writing-modes.https.html An inline ScrollTimeline should produce the correct current time for vertical writing mode and direction: rtl FAIL: 2/10, PASS: 8/10 assert_equals: expected "matrix(1, 0, 0, 1, 0, 50)" but got "matrix(1, 0, 0, 1, 0, 0)"

@stephenmcgruer @majido do you think this is a flaw with the test, or a Chrome bug? If you know Olga's GitHub handle also please poke her here. Thanks!

@majido
Copy link
Member

majido commented Feb 9, 2019

We have noticed that the animation worklet tests have become flaky when composited animations are enabled. I believe wpt is running the tests under regular chrome (as opposed to content_shell) so animations are composited. I am actively investigating this.

It is tracked here on Chromium side: https://bugs.chromium.org/p/chromium/issues/detail?id=930462

@majido
Copy link
Member

majido commented Feb 9, 2019

@foolip per my earlier comment, I think this is an issue that is affecting multiple tests. So I suggest merging this test while I investigate the flakiness. It may be a chrome bug or even if the tests are problematic we have to update them all. So nothing special about this test.

@foolip
Copy link
Member

foolip commented Feb 11, 2019

Thanks @majido for the link, hopefully we'll soon have the ability to link failures to bugs and then we can link to https://bugs.chromium.org/p/chromium/issues/detail?id=930462 for this. I'll go ahead and admin merge.

@foolip foolip merged commit 9d1de21 into master Feb 11, 2019
@foolip foolip deleted the chromium-export-cl-1423537 branch February 11, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees
No one assigned
Labels
animation-worklet chromium-export web-animations wg-css wg-svg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@chromium-wpt-export-bot @lukebjerring @KyleJu @foolip @majido @wpt-pr-bot @ogerchikov