Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singularity: rewrite path to cp in bootstrap script #55286

Merged

Conversation

scalavision
Copy link
Contributor

@scalavision scalavision commented Feb 5, 2019

Motivation for this change

If you use the %files section in the Singularity file, /bin/cp is invoked under the hood when copying. This is not working on NixOS. With this patch, it seems to work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ x] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • [ x] Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Feb 5, 2019

cc @jbedo

@veprbl veprbl merged commit f08b99c into NixOS:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants