Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smlnj: 110.84 -> 110.85 #55287

Merged
merged 1 commit into from Feb 26, 2019
Merged

smlnj: 110.84 -> 110.85 #55287

merged 1 commit into from Feb 26, 2019

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Feb 5, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build smlnj

@ryantm
Copy link
Member

ryantm commented Feb 25, 2019

Build was already failing on Darwin on hydra before this patch.

@vaibhavsagar
Copy link
Member Author

Good to know I haven't broken anything! Is there anything further you need from me here?

@ryantm ryantm merged commit 10f0d40 into NixOS:master Feb 26, 2019
@ryantm
Copy link
Member

ryantm commented Feb 26, 2019

@vaibhavsagar nope, it looks good to me. Thank you; please consider adding yourself as a maintainer.

@vaibhavsagar
Copy link
Member Author

Thanks!

@vaibhavsagar vaibhavsagar deleted the bump-smlnj branch February 26, 2019 16:04
@vaibhavsagar vaibhavsagar mentioned this pull request Jul 10, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vaibhavsagar @matthewbauer @ryantm @GrahamcOfBorg