Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chezmoi: init at 1.3.0 #55368

Merged
merged 1 commit into from Feb 8, 2019
Merged

chezmoi: init at 1.3.0 #55368

merged 1 commit into from Feb 8, 2019

Conversation

jhillyerd
Copy link
Contributor

Motivation for this change

Add powerful new dotfile manager

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jhillyerd jhillyerd mentioned this pull request Feb 7, 2019
Closed
@jhillyerd
Copy link
Contributor Author

jhillyerd commented Feb 8, 2019 •
edited

Good call. With that change, --version output is now:

chezmoi version 1.3.0, commit unknown, built at unknown

Guessing we don't want to set the build date to maximize build reproducibility. Thoughts on commit hash?

@srhb
Copy link
Contributor

srhb commented Feb 8, 2019

@jhillyerd version seems good enough to me.

@srhb srhb merged commit 6f10a0d into NixOS:master Feb 8, 2019
@jhillyerd jhillyerd deleted the chezmoi branch February 8, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhillyerd @srhb @GrahamcOfBorg