Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toybox: init at 0.8.0 #55367

Merged
merged 1 commit into from Feb 28, 2019
Merged

toybox: init at 0.8.0 #55367

merged 1 commit into from Feb 28, 2019

Conversation

hhm0
Copy link
Contributor

@hhm0 hhm0 commented Feb 7, 2019 •
edited

B"H

toybox package, supporting static building via enableStatic parameter, and custom configuration via extraConfig and enableMinimal parameters
parseconfig shell function, and misc other parts, are based on the busybox package derivation.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hhm0 hhm0 changed the title toybox: init at 0.7.8 toybox: init at 0.8.0 Feb 14, 2019
infinisil
infinisil requested changes Feb 18, 2019
View reviewed changes
pkgs/tools/misc/toybox/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/toybox/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/toybox/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/toybox/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/toybox/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/toybox/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/toybox/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/toybox/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/toybox/default.nix Show resolved Hide resolved
@hhm0 hhm0 force-pushed the toybox branch 2 times, most recently from fc8878e to 9d0d979 Compare February 27, 2019 03:36
@hhm0
Copy link
Contributor Author

hhm0 commented Feb 27, 2019

@infinisil Thanks for the reviews! Is this package good to go?

@infinisil
Copy link
Member

Cool, now you just need to squash the commits into one :)

@hhm0
toybox: init at 0.8.0
88e69db 
B"H toybox package, supporting static building via enableStatic, and custom configurations via extraConfig and enableMinimal parameters
parseconfig shell function, and misc other parts, are based on busybox package derivation
@hhm0
Copy link
Contributor Author

hhm0 commented Feb 28, 2019

Cool, now you just need to squash the commits into one :)

Done :-)

@infinisil infinisil merged commit 7387854 into NixOS:master Feb 28, 2019
@dtzWill
Copy link
Member

dtzWill commented Feb 28, 2019

Installing binaries into usr/bin and usr/sbin isn't very Nix-y, and won't appear on PATH properly.

Consider using install_flat as I did when packaging this: https://github.com/dtzWill/nur-packages/blob/d471d48956c51f4b31f7229baf8a3896c1fbaa11/pkgs/toybox/default.nix .

@hhm0 hhm0 mentioned this pull request Mar 1, 2019
Merged
10 tasks
@hhm0
Copy link
Contributor Author

hhm0 commented Mar 1, 2019

Installing binaries into usr/bin and usr/sbin isn't very Nix-y, and won't appear on PATH properly.

Consider using install_flat as I did when packaging this: https://github.com/dtzWill/nur-packages/blob/d471d48956c51f4b31f7229baf8a3896c1fbaa11/pkgs/toybox/default.nix .

Thanks @dtzWill! Opened #56556 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hhm0 @infinisil @dtzWill @GrahamcOfBorg