Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crawl: A few improvements #55324

Merged
merged 3 commits into from Feb 8, 2019
Merged

crawl: A few improvements #55324

merged 3 commits into from Feb 8, 2019

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Feb 6, 2019 •
edited

Motivation for this change

It would be good if this could be merged for 19.03

The repo URL has changed.

Add full game name to description: I didn't find the game when searching for it and invested quite some time to package it myself. Having the game title in the description makes the package easier to discover.

Add support for music.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Moredread
crawl: Update repo url
61a20d6
@Moredread
crawl: Add full game name to description
e06eb19 
I didn't find the game when searching for it and invested quite some
time to package it myself. Having the game title in the description
makes the package easier to discover.
@Moredread
crawl: Add option for sound support and enable it in tileMode by default
d7be766
@Moredread
Copy link
Contributor Author

@GrahamcOfBorg build crawl crawlTiles

@Moredread
Copy link
Contributor Author

cc @abbradar

@matthewbauer matthewbauer merged commit 1eb0d79 into NixOS:master Feb 8, 2019
@Moredread Moredread deleted the crawl branch February 9, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @matthewbauer @GrahamcOfBorg