Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firejail: 0.9.56 -> 0.9.58 #55322

Merged
merged 1 commit into from Feb 10, 2019
Merged

firejail: 0.9.56 -> 0.9.58 #55322

merged 1 commit into from Feb 10, 2019

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Feb 6, 2019

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/firejail/versions.

meta.description for firejail is: '"Namespace-based sandboxing tool for Linux"'.

Checks done (click to expand)
  • built on NixOS
  • Warning: no invocation of /nix/store/92n01l68asymyv48p7if4ck22wp06695-firejail-0.9.58/bin/firejail had a zero exit code or showed the expected version
  • /nix/store/92n01l68asymyv48p7if4ck22wp06695-firejail-0.9.58/bin/firemon passed the binary check.
  • /nix/store/92n01l68asymyv48p7if4ck22wp06695-firejail-0.9.58/bin/firecfg passed the binary check.
  • 2 of 3 passed binary check by having a zero exit code.
  • 2 of 3 passed binary check by having the new version present in output.
  • found 0.9.58 with grep in /nix/store/92n01l68asymyv48p7if4ck22wp06695-firejail-0.9.58
  • directory tree listing: https://gist.github.com/adfd85a02c278175d39675af68a3182f
  • du listing: https://gist.github.com/fe5adf1ab391e332dfcb3257372e413f
Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
firejail

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/92n01l68asymyv48p7if4ck22wp06695-firejail-0.9.58 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A firejail https://github.com/r-ryantm/nixpkgs/archive/0e28f3c31883bff7b4ea19cba77d66416418d10c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/92n01l68asymyv48p7if4ck22wp06695-firejail-0.9.58
ls -la /nix/store/92n01l68asymyv48p7if4ck22wp06695-firejail-0.9.58/bin

cc @7c6f434c for testing.

@r-ryantm
firejail: 0.9.56 -> 0.9.58
0e28f3c 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/firejail/versions
@mrVanDalo
Copy link
Contributor

Tested it using

nix-review pr 55322

Problem is that firejail needs a sticky bit. So I could only test it using sudo firejail. I tested that with some parameters, and it worked fine.

Don't know if this is enough, to merge this pull-request.

@Mic92
Copy link
Member

Mic92 commented Feb 6, 2019

@GrahamcOfBorg build firejail

@7c6f434c 7c6f434c merged commit ff343f3 into NixOS:master Feb 10, 2019
@7c6f434c
Copy link
Member

@mrVanDalo Thanks for the testing! firejail is a bit of magic in advance use anyway, and I don't think the way of giving it privileges has ever mattered.

@r-ryantm r-ryantm deleted the auto-update/firejail branch February 15, 2019 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-ryantm @mrVanDalo @Mic92 @7c6f434c @GrahamcOfBorg