Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python package set: mostly patch updates #54186

Merged
merged 133 commits into from Jan 18, 2019
Merged

Python package set: mostly patch updates #54186

merged 133 commits into from Jan 18, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jan 17, 2019

Motivation for this change

https://hydra.nixos.org/jobset/nixpkgs/python-unstable

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

Do you think we can update requests to 2.21.0? Do requests bumps usually yield a lot of failures?

@dotlambda
Copy link
Member

dotlambda commented Jan 18, 2019

The last few fixes are all due to 05232ab. Please have a look especially at adea7a2.

@FRidh
Copy link
Member Author

FRidh commented Jan 18, 2019

Thanks @dotlambda. I am removing a bunch of the pkgconfig changes because those were already correct.

@FRidh FRidh merged commit 824a185 into staging Jan 18, 2019
timokau added a commit to timokau/nixpkgs that referenced this pull request Feb 2, 2019
Since NixOS#48841 was replaced by
NixOS#54186, this needs to be done
separately.
timokau added a commit that referenced this pull request Feb 2, 2019
Since #48841 was replaced by
#54186, this needs to be done
separately.
@dotlambda dotlambda mentioned this pull request Feb 2, 2019
10 tasks
@vcunat
Copy link
Member

vcunat commented Feb 3, 2019

I noticed many new google-cloud-* failures on staging-next Hydra:

Collecting google-cloud-core<0.30dev,>=0.29.0 (from google-cloud-dns==0.29.2)
  Could not find a version that satisfies the requirement google-cloud-core<0.30dev,>=0.29.0 (from google-cloud-dns==0.29.2) (from versions: )
No matching distribution found for google-cloud-core<0.30dev,>=0.29.0 (from google-cloud-dns==0.29.2)

... so you just forgot commit with google-cloud-core update somewhere? (I don't know your workflow.)

@dotlambda
Copy link
Member

I have pushed appropriate updates to staging-next.

timokau added a commit to timokau/nixpkgs that referenced this pull request Feb 11, 2019
Since NixOS#48841 was replaced by
NixOS#54186, this needs to be done
separately.

(cherry picked from commit 33db01e)
timokau added a commit to timokau/nixpkgs that referenced this pull request Feb 11, 2019
Since NixOS#48841 was replaced by
NixOS#54186, this needs to be done
separately.

(cherry picked from commit 33db01e)
timokau added a commit that referenced this pull request Feb 11, 2019
Since #48841 was replaced by
#54186, this needs to be done
separately.

(cherry picked from commit 33db01e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants