Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildPython*: enable strictDeps #54182

Closed
wants to merge 1 commit into from
Closed

buildPython*: enable strictDeps #54182

wants to merge 1 commit into from

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jan 17, 2019

Motivation for this change

Continuation of #53445.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh added 6.topic: python 2.status: work-in-progress 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on labels Jan 17, 2019
@FRidh FRidh mentioned this pull request Jan 17, 2019
Closed
12 tasks
@FRidh
Copy link
Member Author

FRidh commented Feb 14, 2019

Included in #55757

@dotlambda
Copy link
Member

@FRidh Can you please add a paragraph to the manual explaining nativeBuildInputs vs buildInputs for Python packages? I'm especially interested in cases such as pytestrunner.

@FRidh
Copy link
Member Author

FRidh commented Feb 15, 2019

Done, see 4bd168e

@dotlambda
Copy link
Member

Thanks a lot!

@FRidh
Copy link
Member Author

FRidh commented Feb 22, 2019

This feature ended up in staging-next so closing.

@FRidh FRidh closed this Feb 22, 2019
timokau added a commit to timokau/nixpkgs that referenced this pull request Mar 3, 2019
@timokau
python.pkgs.rpy2: fix strictDeps fallout
c6e4e1d 
See NixOS#54182 and
NixOS#55757.
timokau added a commit to timokau/nixpkgs that referenced this pull request Mar 3, 2019
@timokau
sage: fix strictDeps fallout
9e37547 
See NixOS#54182 and
NixOS#55757.
@dotlambda dotlambda mentioned this pull request Mar 4, 2019
Closed
@dnaq dnaq mentioned this pull request Mar 5, 2019
Closed
@jtojnar jtojnar mentioned this pull request Mar 6, 2019
Closed
timokau added a commit to timokau/nixpkgs that referenced this pull request Mar 10, 2019
@timokau
sage: fix strictDeps fallout
d5230eb 
See NixOS#54182 and
NixOS#55757.

(cherry picked from commit 9e37547)
timokau added a commit to timokau/nixpkgs that referenced this pull request Mar 10, 2019
@timokau
python.pkgs.rpy2: fix strictDeps fallout
de9921e 
See NixOS#54182 and
NixOS#55757.

(cherry picked from commit c6e4e1d)
@jtojnar jtojnar mentioned this pull request Mar 10, 2019
Closed
dotlambda pushed a commit that referenced this pull request Mar 15, 2019
python.pkgs.rasterio: fix build
419503e 
fallout of #54182

(cherry picked from commit f704bee)
dotlambda pushed a commit that referenced this pull request Mar 15, 2019
python.pkgs.rasterio: fix build
f704bee 
fallout of #54182
dotlambda pushed a commit that referenced this pull request Mar 16, 2019
python.pkgs.PyICU: fix build
698ce52 
fallout of #54182

(cherry picked from commit f715658)
voobscout pushed a commit to voobscout/nixpkgs that referenced this pull request Mar 16, 2019
python.pkgs.PyICU: fix build
f715658 
fallout of NixOS#54182
dotlambda pushed a commit that referenced this pull request Mar 18, 2019
python.pkgs.mysqlclient: fix build
0dd99c0 
fallout of #54182
fixes #57263

(cherry picked from commit ea7885f)
pull bot pushed a commit to milibopp/nixpkgs that referenced this pull request Mar 18, 2019
python.pkgs.mysqlclient: fix build
ea7885f 
fallout of NixOS#54182
fixes NixOS#57263
dotlambda pushed a commit to dotlambda/nixpkgs that referenced this pull request Mar 19, 2019
python.pkgs.mecab-python3: fix build
06bcb5c 
fallout of NixOS#54182
dotlambda pushed a commit that referenced this pull request Mar 21, 2019
python.pkgs.mecab-python3: fix build
3594a2d 
fallout of #54182

(cherry picked from commit 06bcb5c)
dotlambda pushed a commit to dotlambda/nixpkgs that referenced this pull request Mar 21, 2019
python.pkgs.python-mapnik: fix build
8519983 
fallout of NixOS#54182
dotlambda pushed a commit that referenced this pull request Mar 22, 2019
python.pkgs.python-mapnik: fix build
3560766 
fallout of #54182

(cherry picked from commit 8519983)
dotlambda pushed a commit that referenced this pull request Mar 26, 2019
python.pkgs.pytest-faulthandler: fix build
921b2cc 
fallout of #54182

(cherry picked from commit 2413b2a)
dotlambda pushed a commit that referenced this pull request Mar 26, 2019
python.pkgs.pytest-faulthandler: fix build
2413b2a 
fallout of #54182
dotlambda pushed a commit to dotlambda/nixpkgs that referenced this pull request Mar 26, 2019
python.pkgs.cartopy: fix build
66804c9 
fallout of NixOS#54182
@dotlambda dotlambda mentioned this pull request Mar 26, 2019
Merged
10 tasks
dotlambda added a commit that referenced this pull request Mar 26, 2019
@dotlambda
python.pkgs.cartopy: fix build (#58361)
29cec94 
fallout of #54182
dotlambda added a commit that referenced this pull request Mar 26, 2019
@dotlambda
python.pkgs.cartopy: fix build (#58361)
409b46d 
fallout of #54182

(cherry picked from commit 29cec94)
This was referenced Apr 3, 2019
Closed
Merged
@dotlambda dotlambda mentioned this pull request Apr 26, 2019
Closed
@kira-bruneau kira-bruneau mentioned this pull request Jul 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FRidh @dotlambda @GrahamcOfBorg