Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smartgithg: 18_1_5 -> 18.2.4 #54177

Merged
merged 1 commit into from Jan 28, 2019
Merged

smartgithg: 18_1_5 -> 18.2.4 #54177

merged 1 commit into from Jan 28, 2019

Conversation

baracoder
Copy link
Contributor

@baracoder baracoder commented Jan 17, 2019 •
edited

This PR is committed using the new version.
The never version requires JRE 10, actually the changelog mentions
downgrading from JDK11 to 10 because of a bug related to https
but this seams to be fixed by now
https://bugs.openjdk.java.net/browse/JDK-8210005

Also I did not find a jre output in jdk11, so the closure size increased due to it.

Motivation for this change

Performance improvements and new features.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested execution of all binary files (usually in ./result/bin/) (This PR is created using the new version)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
18_1_5	  437357072
18_2_4	  755698280
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc maintainer @jraygauthier

@baracoder
smartgithg: 18_1_5 -> 18.2.4
e036a3d 
This PR is committed using the new version.
The never version requires JRE 10, actually the changelog mentions
downgrading from JDK11 to 10 because of a bug related to https
but this seams to be fixed by now
https://bugs.openjdk.java.net/browse/JDK-8210005

Also I did not find a `jre` output in jdk11, so the closure size
might increase due to it.
@baracoder baracoder changed the title smartgithg: 18_1_5 -> 18_2_4 smartgithg: 18_1_5 -> 18.2.4 Jan 28, 2019
@infinisil infinisil merged commit 7088d3f into NixOS:master Jan 28, 2019
@baracoder baracoder deleted the smartigt-18_2_4 branch January 28, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@baracoder @infinisil @GrahamcOfBorg