Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPF: Ship: Assertion failure when ship encounters shore #7226

Closed
JGRennison opened this issue Feb 14, 2019 · 2 comments
Closed

NPF: Ship: Assertion failure when ship encounters shore #7226

JGRennison opened this issue Feb 14, 2019 · 2 comments
Labels
bug Something isn't working regression It used to work, and now it's broken.
Milestone
1.9.0

Comments

@JGRennison
Copy link
Contributor

Version of OpenTTD

Trunk (since commit d814dd3)

Expected result

No assert failures occur

Actual result

Assertion: Error: Assertion failed at line 1166 of /home/jgr/openttd/trunk/src/pathfinder/npf/npf.cpp: ftd.best_trackdir != INVALID_TRACKDIR can be triggered by obstacles in the path of ships when using NPF pathfinder.
This assertion was added in d814dd3 (PR #7114)

Steps to reproduce

See attached savegame. The issue seems to occur when the ship is travelling in a diagonal (with reference to the tile axes) direction and encounters a perpendicular shore slope.
JGR Testing & Maintenance Ltd, 1945-09-12.sav.zip
@PeterN PeterN added bug Something isn't working regression It used to work, and now it's broken. labels Feb 14, 2019
@PeterN PeterN added this to the 1.9.0 milestone Feb 14, 2019
@PeterN
Copy link
Member

PeterN commented Feb 14, 2019

Should be pretty simple to revert just that single hunk from d814dd3. I can prepare this later.

@PeterN PeterN mentioned this issue Feb 14, 2019
Closed
@J0anJosep
Copy link
Contributor

I will look into it. NPF shouldn't be executed on that case. It seems a 90º turn problem. I will look into it this weekend. Reverting the previous changes is doable, but it would be better to modify the ShipController code and keep the asserts on NPF.

J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Feb 14, 2019
@J0anJosep
Fix OpenTTD#7226: Don't call ship pathfinders if there is no availabl…
8858b8f 
…e track due to "forbid 90 deg turns".
J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Feb 18, 2019
@J0anJosep
Fix OpenTTD#7224 OpenTTD#7226: OPF doesn't take 90 deg turns into acc…
a3c2f2d 
…ount.
J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Feb 18, 2019
@J0anJosep
Fix OpenTTD#7224, OpenTTD#7226: OPF doesn't take 90 deg turns into ac…
8b37c42 
…count.
J0anJosep added a commit to J0anJosep/OpenTTD that referenced this issue Feb 18, 2019
@J0anJosep
Fix OpenTTD#7244, OpenTTD#7226: OPF doesn't take 90 deg turns into ac…
75e79bc 
…count.
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
@J0anJosep @nielsmh
Fix OpenTTD#7226: Don't call ship pathfinders if there is no availabl…
e69501e 
…e track due to "forbid 90 deg turns".
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@J0anJosep @douiwby
Fix OpenTTD#7226: Don't call ship pathfinders if there is no availabl…
bd4cd51 
…e track due to "forbid 90 deg turns".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working regression It used to work, and now it's broken.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

Fix #7226: Partial revert of 7d06fec799 for ship pathfinding. PeterN/OpenTTD
3 participants
@PeterN @J0anJosep @JGRennison