Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages_10_x.@angular/cli: init at 7.3.1 #55691

Merged
merged 1 commit into from Feb 18, 2019
Merged

nodePackages_10_x.@angular/cli: init at 7.3.1 #55691

merged 1 commit into from Feb 18, 2019

Conversation

dgarzon
Copy link
Contributor

@dgarzon dgarzon commented Feb 13, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Feb 15, 2019

@dgarzon there seems to be some conflicts. Could you rebase to latest master?

@dgarzon dgarzon force-pushed the node-packages-10-x-angular-cli branch from ecf6dde to 117559b Compare February 18, 2019 11:02
@dgarzon
Copy link
Contributor Author

dgarzon commented Feb 18, 2019

@flokli Done!

@flokli
Copy link
Contributor

flokli commented Feb 18, 2019

@GrahamcOfBorg eval

@flokli
Copy link
Contributor

flokli commented Feb 18, 2019

@GrahamcOfBorg build nodePackages_10_x.@angular/cli

@flokli
Copy link
Contributor

flokli commented Feb 18, 2019

I did build it and was able to ng new my-app; cd my-app; ng serve --open.

I wasn't able to get this in nix-shell working, most likely due to the "@" in the attribute name:

⇒  nix-shell -p "nodePackages_10_x.@angular/cli" -I nixpkgs=$PWD --run zsh              
error: syntax error, unexpected '@', expecting ID or OR_KW or DOLLAR_CURLY or '"', at (string):1:112

… but given there's also @vue/cli, @webassemblyjs/cli etc., I'd rather see this a bug nix nix-shell, not a problem with how it's named here.

@flokli
Copy link
Contributor

flokli commented Feb 18, 2019

The eval failure with pandoc seems to be unrelated, cc @grahamc

@flokli flokli merged commit 107215c into NixOS:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dgarzon @flokli @GrahamcOfBorg