New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all-packages.nix: move defaults to package files continues #55732
all-packages.nix: move defaults to package files continues #55732
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to wait for objections, not just for ofborg, but I do like this
I tend towards liking it as well, but don't have any thought out rationale. cc @volth objected to doing something like this for chromium, IIRC |
This one is a bit untrivial.
and fix some eol spaces.
345d5df
to
e295651
Compare
Well, ofborg, I guess I can just make this a noop. |
I wonder, what ofborg thinks is a rebuild on darwin? nix-env diff between master and a merge of this and master is empty on my machine. Anyway, can we merge yet? |
ofborg seems to think In the GitHub interface, in the list of checks from ofborg, the Details link on the grahamcofborg-eval line will point to a gist with the list of changed attributes. (There is an annoying bug in GitHub where a merged PR will add a bogus Details link to all lines, even those without a Details page to link to.) In case you're ever curious what ofborg saw. This might be a good place to start checking how it sniffs changes. (Most of the implementation is in outpathdiff.rs.) |
I see. Thanks! and for pointers.
|
What? Why?
A continuation of #55129. This one also integrates a bit of #35374.
git log
A bunch of these.
nix-instantiate
environmentnix-env -qaP
diffs/cc @Mic92 @ryantm @Ericson2314 @infinisil @bendlas @jtojnar @pbogdan @abbradar from git-blame and @7c6f434c from #55129