Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all-packages.nix: move defaults to package files continues #55732

Merged

Conversation

oxij
Copy link
Member

@oxij oxij commented Feb 13, 2019

What? Why?

A continuation of #55129. This one also integrates a bit of #35374.

git log

  • *: move defaults to package file

A bunch of these.

nix-instantiate environment

  • Host OS: Linux 4.9, SLNOS 19.03
  • Nix: nix-env (Nix) 2.1.3
  • Multi-user: yes
  • Sandbox: yes
  • NIXPKGS_CONFIG:
{
  checkMeta = true;
  doCheckByDefault = true;
}

nix-env -qaP diffs

  • On x86_64-linux: noop
  • On aarch64-linux: noop
  • On x86_64-darwin: noop

/cc @Mic92 @ryantm @Ericson2314 @infinisil @bendlas @jtojnar @pbogdan @abbradar from git-blame and @7c6f434c from #55129

Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to wait for objections, not just for ofborg, but I do like this

@bendlas
Copy link
Contributor

bendlas commented Feb 13, 2019

I tend towards liking it as well, but don't have any thought out rationale.

cc @volth objected to doing something like this for chromium, IIRC

@oxij oxij force-pushed the tree/move-defaults-to-package-files-mostly-pulse branch from 345d5df to e295651 Compare February 13, 2019 23:15
@oxij
Copy link
Member Author

oxij commented Feb 13, 2019

Well, ofborg, I guess I can just make this a noop.

@oxij
Copy link
Member Author

oxij commented Feb 14, 2019

I wonder, what ofborg thinks is a rebuild on darwin? nix-env diff between master and a merge of this and master is empty on my machine.

Anyway, can we merge yet?

@samueldr samueldr merged commit f8eef26 into NixOS:master Feb 15, 2019
@samueldr
Copy link
Member

samueldr commented Feb 15, 2019

ofborg seems to think direwolf has changed for darwin. Though it's something that fails to instantiate here, and looked unrelated?


In the GitHub interface, in the list of checks from ofborg, the Details link on the grahamcofborg-eval line will point to a gist with the list of changed attributes.

image

(There is an annoying bug in GitHub where a merged PR will add a bogus Details link to all lines, even those without a Details page to link to.)

In case you're ever curious what ofborg saw. This might be a good place to start checking how it sniffs changes. (Most of the implementation is in outpathdiff.rs.)

@oxij
Copy link
Member Author

oxij commented Feb 17, 2019 via email

@oxij oxij deleted the tree/move-defaults-to-package-files-mostly-pulse branch August 12, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants