Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fd: 7.2.0 -> 7.3.0 #55731

Merged
merged 1 commit into from Feb 15, 2019
Merged

fd: 7.2.0 -> 7.3.0 #55731

merged 1 commit into from Feb 15, 2019

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Feb 13, 2019 •
edited

changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and works fine on NixOS.

Don't know what's up with the darwin build.

@thoughtpolice
Copy link
Member

@GrahamcOfBorg build fd

@thoughtpolice
Copy link
Member

The error makes me think we were just being haunted by ghosts earlier. But the ghosts may be gone now, so let's see!

installing
    Updating registry `https://github.com/rust-lang/crates.io-index`
error: failed to sync
Caused by:
  failed to load pkg lockfile
Caused by:
  failed to fetch `https://github.com/rust-lang/crates.io-index`
Caused by:
  [16/-1] unexpected return value from ssl handshake -9808

@xeji
Copy link
Contributor

xeji commented Feb 15, 2019

looks like rustc build succeeded on Hydra in the meantime, so let's try again
@GrahamcOfBorg build fd

@xeji
Copy link
Contributor

xeji commented Feb 15, 2019

Now the timeouts are gone but it's the same Darwin error again:

Caused by:
  failed to fetch `https://github.com/rust-lang/crates.io-index`
Caused by:
  [16/-1] unexpected return value from ssl handshake -9808

@xeji
Copy link
Contributor

xeji commented Feb 15, 2019

Since this doesn't look like an issue specific to fd I suggest we merge it anyway. Darwin can be fixed later.

@marsam
Copy link
Contributor

marsam commented Feb 15, 2019

FWIW I can build it on darwin https://gist.github.com/10a2319157de357940732fe1c30972f5

@worldofpeace worldofpeace merged commit 4450943 into NixOS:master Feb 15, 2019
@worldofpeace
Copy link
Contributor

Thanks again for the darwin testing @marsam 😄

@dywedir dywedir deleted the fd branch February 17, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dywedir @thoughtpolice @xeji @marsam @worldofpeace @GrahamcOfBorg