nixos/tests/switch-test: Ensures the test fails on failure #55744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `| tee` invocation always masked the return value of the switch-to-configuration test. ``` ~ $ false | tee && echo "oh no" oh no ``` The added wrapper script will still output everything to stderr, while passing failures to the test harness.
samueldr
force-pushed
the
tests/switch-to-configuration-failure
branch
from
0ba44b5
to
5009f42
Compare
NeQuissimus
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
| teeinvocation always masked the return value of theswitch-to-configuration test.
The added wrapper script will still output everything to stderr, while
passing failures to the test harness.
Things done
This was verified as failing by failing to fail (whew) with the kernel regression in #53672. With this fix applied, and the proper kernel update applied (revert the kernel upgrade revert) it will fail as expected.
sandboxinnix.confon non-NixOS)