Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.aplpy: init at 2.0.3 #55711

Merged
merged 6 commits into from Mar 15, 2019
Merged

pythonPackages.aplpy: init at 2.0.3 #55711

merged 6 commits into from Mar 15, 2019

Conversation

smaret
Copy link
Member

@smaret smaret commented Feb 13, 2019 •
edited

Motivation for this change

Add a Nix expression for the Aplpy Python package and its dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@smaret smaret requested a review from FRidh as a code owner February 13, 2019 15:34
@smaret smaret changed the title Aplpy: init at 2.0.rc2 aplpy: init at 2.0.rc2 Feb 13, 2019
@dotlambda dotlambda changed the title aplpy: init at 2.0.rc2 pythonPackages.aplpy: init at 2.0.rc2 Feb 13, 2019
dotlambda
dotlambda requested changes Feb 13, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the commit messages and fix the evaluation errors.

pkgs/development/python-modules/aplpy/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/aplpy/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/astropy-healpix/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/reproject/default.nix Outdated Show resolved Hide resolved
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.aplpy python3.pkgs.aplpy

@dotlambda
Copy link
Member

Download error on https://pypi.python.org/simple/astropy-helpers/: [Errno -2] Name or service not known -- Some packages may not be found!

@smaret
Copy link
Member Author

smaret commented Feb 13, 2019

Download error on https://pypi.python.org/simple/astropy-helpers/: [Errno -2] Name or service not known -- Some packages may not be found!

Where does this come from?

@dotlambda
Copy link
Member

You will find it in the build log (see the checks):
@GrahamcOfBorg build python2.pkgs.aplpy python3.pkgs.aplpy
It's probably a result of building in the sandbox

@dotlambda
Copy link
Member

Please reorder the commits and squash the last 3 ones into your earlier ones.

@smaret
Copy link
Member Author

smaret commented Feb 14, 2019

@GrahamcOfBorg build python2.pkgs.aplpy python3.pkgs.aplpy

@dotlambda
Copy link
Member

@GrahamcOfBorg build python3.pkgs.aplpy

@dotlambda
Copy link
Member

I still get the same error locally.

@smaret smaret changed the title pythonPackages.aplpy: init at 2.0.rc2 pythonPackages.aplpy: init at 2.0.3 Feb 25, 2019
@smaret
Copy link
Member Author

smaret commented Feb 27, 2019

I'm trying to reproduce this error on macOS with sandboxing, but I get a different error:

% nix-build -I. -A python3Packages.aplpy
these derivations will be built:
  /nix/store/x69p3bkr0dw7s04zvc1mnyh16qmsrxfb-python3.7-aplpy-2.0.3.drv
building '/nix/store/x69p3bkr0dw7s04zvc1mnyh16qmsrxfb-python3.7-aplpy-2.0.3.drv'...
unpacking sources
unpacking source archive /nix/store/kydlzzhjm9d9a838gqbnc50h7wdzk6fi-APLpy-2.0.3.tar.gz
dyld: Library not loaded: @rpath/CoreFoundation.framework/Versions/A/CoreFoundation
  Referenced from: /nix/store/yaxqbxpg4svc97ic2s01gqsd6d5209ar-gnutar-1.31/bin/tar
  Reason: no suitable image found.  Did find:
        /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation: file system sandbox blocked stat()
/nix/store/zchs18skjv75qg2iy0srwz1dvrrmfkv7-stdenv-darwin/setup: line 842: 83909 Abort trap: 6           tar xf "$fn"
do not know how to unpack source archive /nix/store/kydlzzhjm9d9a838gqbnc50h7wdzk6fi-APLpy-2.0.3.tar.gz
builder for '/nix/store/x69p3bkr0dw7s04zvc1mnyh16qmsrxfb-python3.7-aplpy-2.0.3.drv' failed with exit code 1
error: build of '/nix/store/x69p3bkr0dw7s04zvc1mnyh16qmsrxfb-python3.7-aplpy-2.0.3.drv' failed

Is this a bug in the gnutar package?

@dotlambda
Copy link
Member

@smaret I have no experience whatsoever with Darwin. Maybe @matthewbauer can help out.

@smaret
Copy link
Member Author

smaret commented Mar 1, 2019

I've just on opened an issue for the gnutar sandbox issue on Darwin (#56591).

@smaret
Copy link
Member Author

smaret commented Mar 11, 2019

@GrahamcOfBorg build python3.pkgs.aplpy

@smaret
Copy link
Member Author

smaret commented Mar 11, 2019

@GrahamcOfBorg build python3.pkgs.aplpy

@smaret
Copy link
Member Author

smaret commented Mar 11, 2019 •
edited

I finally managed to get the sandbox working on Darwin 🎉

The download error was caused by an automatic update of the astropy-helpers module during the setup. I've patched the setup.cfg to fix it. The build log looks good now.

@smaret
Copy link
Member Author

smaret commented Mar 13, 2019

@dotlambda Can you please have a look at this when you get a chance? I think that the PR is now ready for merging.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python3.pkgs.aplpy

@dotlambda
Copy link
Member

During the build of pyavm I get

Ran 0 tests in 0.000s

Please add an appropriate checkPhase or, if there are no tests, set doCheck = false and add a comment with the reason.

@smaret
Copy link
Member Author

smaret commented Mar 15, 2019

During the build of pyavm I get

Ran 0 tests in 0.000s

Please add an appropriate checkPhase

Done.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python3.pkgs.aplpy

@dotlambda dotlambda merged commit d50fe70 into NixOS:master Mar 15, 2019
@smaret
Copy link
Member Author

smaret commented Mar 15, 2019

Thanks for your detailed review of this PR @dotlambda !

@smaret smaret deleted the aplpy branch March 15, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smaret @dotlambda @GrahamcOfBorg