Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tokenTtl option to kubernetes-dashboard. #55835

Closed
wants to merge 1 commit into from
Closed

Add tokenTtl option to kubernetes-dashboard. #55835

wants to merge 1 commit into from

Conversation

juselius
Copy link
Contributor

The default timeout is 15 minutes, which is quite irritating when developing kubernetes services.

Motivation for this change

The kubernetes dashboard has a default authentication timeout which is only 15 minutes. This PR makes the timeout configurable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@juselius
Add tokenTtl option to kubernetes-dashboard.
1eaf847 
The default timeout is 15 minutes, which is quite irritating when
developing kubernetes services.
@mmahut
Copy link
Member

mmahut commented Aug 20, 2019

Are there any updates on this pull request, please?

@juselius
Copy link
Contributor Author

@mmahut I'll update the patch later this week, and try to get it accepted.

@juselius
Copy link
Contributor Author

@mmahut I think I will retract this PR. I have started to think that the nixos kubernetes addon-manager is a bad idea. It's easy and more flexible to install everything using helm.

The reason I dislike addon-manager is that it breaks with how the rest of the kubernetes system is managed. It's also really quite confusing if you happen to forget that a deployment is managed by the addon-manager, and all your modifications magically get nullified...

@juselius juselius closed this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juselius @mmahut @GrahamcOfBorg