Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler-rt-7.0.1: Fix build on darwin #55698

Merged
merged 1 commit into from Feb 14, 2019
Merged

compiler-rt-7.0.1: Fix build on darwin #55698

merged 1 commit into from Feb 14, 2019

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Feb 13, 2019

Motivation for this change

compiler-rt-7.0.1 does not compile on darwin because nixpkgs' current libSystem does not provide clock_gettime().

Things done

Implemented workaround.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Feb 13, 2019
@tobim tobim mentioned this pull request Feb 13, 2019
Closed
@matthewbauer
Copy link
Member

Great work!!

@matthewbauer matthewbauer merged commit 30c84f5 into NixOS:master Feb 14, 2019
@tobim tobim deleted the compiler-rt-darwin branch February 14, 2019 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tobim @matthewbauer @GrahamcOfBorg