Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kustomize: 1.0.11 -> 2.0.1 #55809

Merged
merged 3 commits into from Feb 15, 2019
Merged

kustomize: 1.0.11 -> 2.0.1 #55809

merged 3 commits into from Feb 15, 2019

Conversation

zaninime
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zaninime
Copy link
Contributor Author

cc @carlosdagos @vdemeester @periklis.

vdemeester
vdemeester reviewed Feb 15, 2019
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zaninime I didn't include deps (using dep2nix initially) as there is a vendor directory in kustomize ; all the dependencies should already be in the source we check out.

Any reason why you needed to add it ?

@zaninime
Copy link
Contributor Author

zaninime commented Feb 15, 2019 via email •
edited

@offlinehacker offlinehacker merged commit 1775f6c into NixOS:master Feb 15, 2019
@zaninime zaninime deleted the kustomize branch February 15, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zaninime @vdemeester @offlinehacker @GrahamcOfBorg