Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lektor: 2.3 -> 3.1.3 #55818

Closed
wants to merge 2 commits into from
Closed

lektor: 2.3 -> 3.1.3 #55818

wants to merge 2 commits into from

Conversation

das-g
Copy link
Member

@das-g das-g commented Feb 15, 2019

Motivation for this change

version bump (Lektor 3.0 has been released in 2017, 3.1 in early 2018 and 3.1.3 on 2019-01-26.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Notes:

  • The derivation seems to be missing the JavaScript part of Lektor, so editing through the web interface provided by lektor server doesn't work. This was already the case with the 2.3 version of the derivation, so isn't a regression of this version bump.
  • Upstream does provide tests, but we don't run them. Should we? If so, can someone help me implement that? If we shouldn't, should we at least remove or change the comment that (falsely) claims "No tests included in archive"?

@joachifm
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.lektor

@joachifm
Copy link
Contributor

Superseded by #59353

@joachifm joachifm closed this Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants